add optional file parameter to allow for use in a loop without object_id clashes #334

stephan · 2022-05-20T11:52:33Z

stephan commented

2022-05-20 11:52:33 +00:00

Hi Nico,

Now with the conditional cat of $file.

Best regards,
Stephan

Hey Stephan,

thanks for the patch. We are using
https://code.ungleich.ch/ungleich-public/cdist for git.

Your patch, generally speaking, looks good. However the unconditional
cat on the file parameter will leave an error message. Instead, I
suggest to do the following:

if [ -f ... ]; then ... fi

Best regards,

Nico

Stephan Leemburg stephan.leemburg@gmail.com writes:

Hi all,

I have a need to use __dot_file in a loop for users to install .vimrc for each user that meets some criteria. This is not possible with the cdist __dot_file, so
I have patched it.

How can I submit the patch? github seems to be not updated anymore, so a pull request there will not work.

Just to be sure, I already attached the patch to this message.

Thank you and best regards,
Stephan

Hi Nico, Now with the conditional cat of $file. Best regards, Stephan Hey Stephan, thanks for the patch. We are using https://code.ungleich.ch/ungleich-public/cdist for git. Your patch, generally speaking, looks good. However the unconditional cat on the `file` parameter will leave an error message. Instead, I suggest to do the following: if [ -f ... ]; then ... fi Best regards, Nico Stephan Leemburg <stephan.leemburg@gmail.com> writes: > Hi all, > > I have a need to use __dot_file in a loop for users to install .vimrc for each user that meets some criteria. This is not possible with the cdist __dot_file, so > I have patched it. > > How can I submit the patch? github seems to be not updated anymore, so a pull request there will not work. > > Just to be sure, I already attached the patch to this message. > > Thank you and best regards, > Stephan

stephan added 1 commit 2022-05-20 11:52:34 +00:00

3d58c9b24f add optional file parameter to allow for use in a loop without object_id clashes

nico commented

2022-05-20 12:53:05 +00:00

That's a nice PR! Will merge it.

nico merged commit 1edc4d0a60 into master

2022-05-20 12:53:14 +00:00

nico referenced this issue from a commit

2022-05-20 12:53:14 +00:00

Merge pull request 'add optional file parameter to allow for use in a loop without object_id clashes' (#334) from stephan/cdist:master into master

Sign in to join this conversation.

No reviewers