ungleich-public/cdist
ungleich-public/cdist
7
4
Fork 10
Code Issues 58 Pull requests 15 Projects Releases Wiki Activity

Handle signed-by option in __apt_source #335

Merged
nico merged 1 commit from fancsali/cdist:apt-source-signed-by into master 2022-07-02 17:20:30 +00:00
Conversation 2 Commits 1 Files changed 4 +22 -6
fancsali commented 2022-07-01 13:32:54 +00:00
Contributor
Copy link

Allow users to specify a GPG key fingerprint or keyring file to be
included as the 'signed-by' option.

Closes #16.

Allow users to specify a GPG key fingerprint or keyring file to be included as the 'signed-by' option. Closes #16.
fancsali added 1 commit 2022-07-01 13:32:55 +00:00 
Allow users to specify a GPG key fingerprint or keyring file to be
included as the 'signed-by' option.
fancsali force-pushed apt-source-signed-by from 9f76574b90 to 3f9f3e07e0 2022-07-01 13:38:44 +00:00 Compare
fancsali force-pushed apt-source-signed-by from 3f9f3e07e0 to d0271e4cd1 2022-07-01 13:42:50 +00:00 Compare
fancsali force-pushed apt-source-signed-by from d0271e4cd1 to 14cd5e3388 2022-07-01 13:48:39 +00:00 Compare
fancsali force-pushed apt-source-signed-by from 14cd5e3388 to 1a3c8f2d63 2022-07-01 13:49:27 +00:00 Compare
fancsali force-pushed apt-source-signed-by from 1a3c8f2d63 to d7ff4469a5 2022-07-01 14:10:53 +00:00 Compare
nico reviewed 2022-07-01 14:26:03 +00:00
cdist/conf/type/__apt_source/manifest Outdated
@ -37,0 +38,4 @@
options="$options signed-by=$(cat "$__object/parameter/signed-by")"
fi
if [ "$options" != "" ]; then
nico commented 2022-07-01 14:26:03 +00:00
Owner
Copy link

This is very unshell alike, I suggest to use:

if [ "$options" ]; then ...
This is very unshell alike, I suggest to use: ``` if [ "$options" ]; then ... ```
fancsali commented 2022-07-01 15:53:45 +00:00
Author
Contributor
Copy link

Et voilá...

Et voilá...
fancsali marked this conversation as resolved
nico commented 2022-07-01 14:26:36 +00:00
Owner
Copy link

Besides one comment, good from my side.

Besides one comment, good from my side.
fancsali force-pushed apt-source-signed-by from d7ff4469a5 to 0ae37b3445 2022-07-01 15:15:00 +00:00 Compare
fancsali commented 2022-07-01 16:44:27 +00:00
Author
Contributor
Copy link

One thing though: this might be looked at in relation with #336 - depending on what the workflow/branching policy is...

One thing though: this might be looked at in relation with #336 - depending on what the workflow/branching policy is...
nico merged commit 5a7542db75 into master 2022-07-02 17:20:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bugfix

   
cleanup

   
discussion

   
documentation

   
doing

   
done

   
feature

   
improvement

   
packaging

   
Stale

   
testing

   
TODO
No labels
bugfix
cleanup
discussion
documentation
doing
done
feature
improvement
packaging
Stale
testing
TODO
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ungleich-public/cdist#335
No description provided.
Delete branch "fancsali/cdist:apt-source-signed-by"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?