Add Check Point Gaia (FW1) management and firewall appliances to explorers #339

Merged
nico merged 6 commits from :master into master 2022-07-29 08:56:10 +00:00
Contributor

Add Check Point Gaia (FW1) management and firewall appliances to explorers

Add Check Point Gaia (FW1) management and firewall appliances to explorers
stephan added 3 commits 2022-07-13 12:52:24 +00:00
stephan added 1 commit 2022-07-28 14:27:19 +00:00
nico reviewed 2022-07-28 15:06:10 +00:00
@ -22,2 +22,4 @@
set +e
case "$("$__explorer/os")" in
checkpoint)
cat /etc/cp-release|sed -e 's/.* R\([1-9][0-9]*\)\.[0-9]*$/\1/'
Owner

You can use sed ... /etc/cp-release directly without the need of cat

You can use `sed ... /etc/cp-release` directly without the need of cat
nico reviewed 2022-07-28 15:07:20 +00:00
@ -39,0 +43,4 @@
fi
printf 'The file "%s" is missing. Please create it before using %s on it.\n' "$file" "${__type##*/}" >&2
exit 1
fi
Owner

This change seems to be a stray change / should probably not be included in this PR

This change seems to be a stray change / should probably not be included in this PR
nico reviewed 2022-07-28 15:07:43 +00:00
@ -30,1 +33,4 @@
ifexists
Only apply the line if the file exists.
Owner

Same same, seems like this change is also incorrect for this PR

Same same, seems like this change is also incorrect for this PR
nico reviewed 2022-07-28 15:09:10 +00:00
@ -118,1 +118,4 @@
# Appliances
if grep -q '^Check Point Gaia' /etc/cp-release 2>/dev/null; then
Owner

Question regarding the string Check Point Gaia - is that the only one to look for? Or are there other Check Point ... devices?

Question regarding the string `Check Point Gaia` - is that the only one to look for? Or are there other `Check Point ...` devices?
Owner

Nice PR, just a few small things to improve

Nice PR, just a few small things to improve
stephan added 1 commit 2022-07-28 15:18:47 +00:00
Owner

@stephan Re line / this branch: the easiest is probably if you remove the line changes from HEAD and force push your branch. https://www.atlassian.com/git/tutorials/rewriting-history is a good start for this.

There is no issue (actually I did not even check the line changes) with the changes, just trying to keep the history clean/merge what can be reviewed easily.

If this is the first checkpoint device we have, let's keep the identification as is, as it is what we know by now. If someone later discovers are more general pattern, we'll switch to that.

@stephan Re line / this branch: the easiest is probably if you remove the line changes from HEAD and force push your branch. https://www.atlassian.com/git/tutorials/rewriting-history is a good start for this. There is no issue (actually I did not even check the line changes) with the changes, just trying to keep the history clean/merge what can be reviewed easily. If this is the first checkpoint device we have, let's keep the identification as is, as it is what we know by now. If someone later discovers are more general pattern, we'll switch to that.
stephan added 1 commit 2022-07-28 15:53:47 +00:00
nico merged commit 7de931829a into master 2022-07-29 08:56:10 +00:00
Owner

Merged. In case you are not yet on Matrix, you might want to checkout https://chat.with.ungleich.ch, there is a channel #cdist:ungleich.ch.

We will soon release cdist 7.0.0 - potentially with the new linux changes.

Merged. In case you are not yet on Matrix, you might want to checkout https://chat.with.ungleich.ch, there is a channel #cdist:ungleich.ch. We will soon release cdist 7.0.0 - potentially with the new linux changes.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ungleich-public/cdist#339
No description provided.