add --create and --ifexists options to line #342

Open

stephan wants to merge 2 commits from stephan/cdist:line_create_ifexists into master

pull from: stephan/cdist:line_create_ifexists

merge into: ungleich-public:master

ungleich-public:master

ungleich-public:7.0

ungleich-public:6.9

ungleich-public:py3.10

ungleich-public:ander/__package_apt_update_index

ungleich-public:haproxy-dualstack

ungleich-public:ander/__sed

ungleich-public:beta

ungleich-public:ander/os_version_debian_sid

ungleich-public:evilham-compatibility-fixes

ungleich-public:ander/__rsync

ungleich-public:__snakeoil_cert

ungleich-public:ander/update_readme

ungleich-public:__download_improvements

ungleich-public:feature/onchange

ungleich-public:cleanup/string-formatting

ungleich-public:feature/type-relationship-graph

ungleich-public:cleanup/ssh-auth-keys-types

ungleich-public:__letsencrypt_cert-fix-hooks

ungleich-public:bugfix/preos-debug

ungleich-public:bugfix/in-script-import

ungleich-public:6.8

ungleich-public:bugfix/sphinx-docs-build

ungleich-public:6.7

ungleich-public:cherry-pick-2f433a14

ungleich-public:bugfix/make-code-consistent

ungleich-public:6.6

ungleich-public:regain-py3.2-support

ungleich-public:6.5

ungleich-public:bugfix/multiple-log-lines

ungleich-public:matterbridge

ungleich-public:coturn

ungleich-public:alpinefix

ungleich-public:matrix

ungleich-public:new-type/network-interface

ungleich-public:feature/process

ungleich-public:6.4

ungleich-public:feature/info-command

ungleich-public:feature/libexec

ungleich-public:6.3

ungleich-public:preos-plugins-dir-opt

ungleich-public:gitlab-ci

ungleich-public:6.2

ungleich-public:order-dep-fix

ungleich-public:6.1

ungleich-public:6.0

ungleich-public:build/support-pip-from-git

ungleich-public:feature/shell-lib

ungleich-public:5.1

ungleich-public:feature/support-type-deprecation

ungleich-public:5.0

ungleich-public:feature/python-types

ungleich-public:4.11

ungleich-public:4.10

ungleich-public:shellcheck

ungleich-public:4.9

ungleich-public:4.8

ungleich-public:freebsd-improvements

ungleich-public:new-prometheus

ungleich-public:key_value-onchange

ungleich-public:feature/output_streams

ungleich-public:AnotherKamila-patch-1

ungleich-public:__letsencrypt_cert-fixes

ungleich-public:letsencrypt-cron-fix

ungleich-public:4.7

ungleich-public:newtype-__letsencrypt_cert

ungleich-public:os_explorer_devuan_fix

ungleich-public:prometheus-exporter-fixes

ungleich-public:daemontools-for-fbsd

ungleich-public:type-prometheus-exporter-from-master

ungleich-public:prometheus-more-fixes

ungleich-public:4.6

ungleich-public:4.5

ungleich-public:fix-j

ungleich-public:steven-backport

ungleich-public:4.4

ungleich-public:prometheus-fixes

ungleich-public:grafana_dashboard

ungleich-public:prometheus

ungleich-public:daemontools

ungleich-public:consul_improvements

ungleich-public:feature/trigger

ungleich-public:4.3

ungleich-public:4.0-pre-not-stable

ungleich-public:4.2

ungleich-public:4.1

ungleich-public:4.0

ungleich-public:feature_install_and_preos

ungleich-public:3.1

ungleich-public:no-dot-cdist

ungleich-public:random_dot_cdist

ungleich-public:feature_yum_url

ungleich-public:feature_files_export

ungleich-public:3.0

ungleich-public:2.3

ungleich-public:2.2

ungleich-public:2.1

ungleich-public:ssh_callback

ungleich-public:2.0

ungleich-public:archive_shell_function_approach

ungleich-public:1.7

ungleich-public:1.6

ungleich-public:1.5

ungleich-public:1.4

ungleich-public:1.3

ungleich-public:1.2

ungleich-public:1.1

ungleich-public:1.0

Conversation 2 Commits 2 Files changed 6 +23 -2

stephan commented 2022-07-29 20:48:30 +00:00

Contributor

Copy link

Add the options create to create the file if it does not exist and ifexists to skip the modification if the file does not exist.

Add the options create to create the file if it does not exist and ifexists to skip the modification if the file does not exist.

stephan added 1 commit 2022-07-29 20:48:32 +00:00

add --create and --ifexists options to line a379bfc742

nico commented 2022-07-31 09:25:21 +00:00

Owner

Copy link

Hey @stephan ! How is --create different from the exact same version of the file type? I.e. what do we gain by adding this?

Hey @stephan ! How is --create different from the exact same version of the file type? I.e. what do we gain by adding this?

nico commented 2022-07-31 09:30:55 +00:00

Owner

Copy link

In regards to ifexists, I understand that there might be a use case (would be great if you can add this one to the documenntation part), but I find the naming a bit tricky:

• ifexists might imply that "only do things if the file exists", which is the default
• ifexists might refer to an existing line

I was first inclined to name it "only-if-file-exists", but that actually does not describe the situation. The introduced behaviour is:

• Ignore the line if the file does not exist

So the most reasonable parameter that comes to my mind would be: ignore-if-file-does-not-exist, which we might want to shrink down a little bit.

Open for suggestions, but I don't think ifexists is the final one.

In regards to `ifexists`, I understand that there might be a use case (would be great if you can add this one to the documenntation part), but I find the naming a bit tricky: * ifexists might imply that "only do things if the file exists", which is the default * ifexists might refer to an existing line I was first inclined to name it "only-if-file-exists", but that actually does not describe the situation. The introduced behaviour is: * Ignore the line if the file does not exist So the most reasonable parameter that comes to my mind would be: `ignore-if-file-does-not-exist`, which we might want to shrink down a little bit. Open for suggestions, but I don't think `ifexists` is the final one.

stephan added 1 commit 2022-07-31 17:30:49 +00:00

only-if-file-present 55d6e21a1d

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u line_create_ifexists:stephan-line_create_ifexists

git checkout stephan-line_create_ifexists

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master

git merge --no-ff stephan-line_create_ifexists

git checkout stephan-line_create_ifexists

git rebase master

git checkout master

git merge --ff-only stephan-line_create_ifexists

git checkout stephan-line_create_ifexists

git rebase master

git checkout master

git merge --no-ff stephan-line_create_ifexists

git checkout master

git merge --squash stephan-line_create_ifexists

git checkout master

git merge --ff-only stephan-line_create_ifexists

git checkout master

git merge stephan-line_create_ifexists

git push origin master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bugfix

  

cleanup

  

discussion

  

documentation

  

doing

  

done

  

feature

  

improvement

  

packaging

  

Stale

  

testing

  

TODO

No labels

bugfix

cleanup

discussion

documentation

doing

done

feature

improvement

packaging

Stale

testing

TODO

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ungleich-public/cdist#342

No description provided.