evilham evilham
  • Joined on 2021-11-20
evilham commented on pull request ungleich-public/cdist-contrib#31 2024-05-24 22:05:58 +00:00
opendkim: fix freebsd startonboot

Replaced with !33

evilham suggested changes for ungleich-public/cdist-contrib#32 2024-05-24 12:38:26 +00:00
[__opendkim*] add debian support

Hey, the general gist of this review is:

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:26 +00:00
[__opendkim*] add debian support

This seems redundant as it is the default.

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:26 +00:00
[__opendkim*] add debian support

Given that USERID exists for the --userid parameter, which was deprecated, I think this should instead (or additionally) check for the UserID being defined in --extra-config, and if not, appending the corresponding line; similar to --processid.

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:26 +00:00
[__opendkim*] add debian support

Same nit-pick as for __opendkim, I'd suggest using alphabetical sorting.

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:26 +00:00
[__opendkim*] add debian support

It seems like we are not using this really, can we remove it?

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:25 +00:00
[__opendkim*] add debian support

Rather than add more parameters to the type (we don't want to support 100% of the .conf), I'd propose we rely on --custom-config instead.

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:25 +00:00
[__opendkim*] add debian support

I'd probably propose we keep only the *) case, or we leave DIRECTORY="/var/db/dkim/" outside of the case block, and only keep the 'debian') case.

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:25 +00:00
[__opendkim*] add debian support

Nit-pick: could we write things alphabetically here? :-D

evilham created pull request ungleich-public/cdist-contrib#33 2024-05-24 11:39:20 +00:00
__opendkim: fix start_on_boot on FreeBSD
evilham closed pull request ungleich-public/cdist-contrib#31 2024-05-24 11:39:02 +00:00
opendkim: fix freebsd startonboot
evilham reopened pull request ungleich-public/cdist-contrib#31 2024-05-24 11:37:16 +00:00
opendkim: fix freebsd startonboot
evilham closed pull request ungleich-public/cdist-contrib#31 2024-05-24 11:35:29 +00:00
opendkim: fix freebsd startonboot
evilham commented on pull request ungleich-public/cdist-contrib#31 2024-05-24 11:32:10 +00:00
opendkim: fix freebsd startonboot

Closing this MR as gitea borked it when updating it.

Anyway, adding this comment to the manifest:

# Due to the way rc.conf works on *BSD, we find ourselves in the awkward
# situation, where a…
evilham created pull request ungleich-public/cdist-contrib#31 2024-05-16 10:39:38 +00:00
opendkim-freebsd-startonboot
evilham pushed to opendkim-freebsd-startonboot at ungleich-public/cdist-contrib 2024-05-16 10:37:46 +00:00
bebd83cfa6 __opendkim: fix start_on_boot on FreeBSD
evilham created branch opendkim-freebsd-startonboot in ungleich-public/cdist-contrib 2024-05-16 10:37:45 +00:00
evilham commented on pull request ungleich-public/cdist-contrib#28 2024-05-16 10:20:51 +00:00
[__opendkim*] add debian support

Will you do the rebase/conflict resolution? or should I do that and test changes?

evilham created pull request ungleich-public/cdist-contrib#30 2024-05-16 10:17:46 +00:00
jitsi-updates
evilham created branch jitsi-updates in ungleich-public/cdist-contrib 2024-05-16 10:04:54 +00:00