• Joined on 2021-11-20
evilham pushed to master at ungleich-public/cdist-contrib 2025-08-27 09:44:12 +00:00
8763095e50 __jitsi_meet: upgrade to 2.0.10431
evilham pushed to master at ungleich-public/cdist-contrib 2025-07-02 16:02:27 +00:00
4ad8a4bbe0 __jitsi_meet: fix typo introduced in latest upgrade
evilham pushed to master at ungleich-public/cdist-contrib 2025-07-02 15:39:47 +00:00
14ea884558 __jitsi_meet: disable reaction sounds
evilham pushed to master at ungleich-public/cdist-contrib 2025-07-02 14:27:05 +00:00
ca1eba2b22 __jitsi_meet: upgrade to 2.0.10314
evilham pushed to master at ungleich-public/cdist-contrib 2025-05-05 18:23:42 +00:00
7c0ec375ff __single_binary_service: fix oddities when removing a service
evilham pushed to master at ungleich-public/cdist-contrib 2025-04-26 16:52:27 +00:00
05f7711bb3 __single_binary_service: add more features
evilham pushed to master at ungleich-public/cdist-contrib 2025-04-11 08:21:20 +00:00
0f6b03b7c1 __jitsi_meet: upgrade to 2.0.10184
evilham commented on pull request ungleich-public/cdist-contrib#31 2024-05-24 22:05:58 +00:00
opendkim: fix freebsd startonboot

Replaced with !33

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:26 +00:00
[__opendkim*] add debian support

Same nit-pick as for __opendkim, I'd suggest using alphabetical sorting.

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:26 +00:00
[__opendkim*] add debian support

Given that USERID exists for the --userid parameter, which was deprecated, I think this should instead (or additionally) check for the UserID being defined in --extra-config, and if not, appending the corresponding line; similar to --processid.

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:26 +00:00
[__opendkim*] add debian support

This seems redundant as it is the default.

evilham suggested changes for ungleich-public/cdist-contrib#32 2024-05-24 12:38:26 +00:00
[__opendkim*] add debian support

Hey, the general gist of this review is:

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:26 +00:00
[__opendkim*] add debian support

It seems like we are not using this really, can we remove it?

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:25 +00:00
[__opendkim*] add debian support

I'd probably propose we keep only the *) case, or we leave DIRECTORY="/var/db/dkim/" outside of the case block, and only keep the 'debian') case.

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:25 +00:00
[__opendkim*] add debian support

Rather than add more parameters to the type (we don't want to support 100% of the .conf), I'd propose we rely on --custom-config instead.

evilham commented on pull request ungleich-public/cdist-contrib#32 2024-05-24 12:38:25 +00:00
[__opendkim*] add debian support

Nit-pick: could we write things alphabetically here? :-D

evilham created pull request ungleich-public/cdist-contrib#33 2024-05-24 11:39:20 +00:00
__opendkim: fix start_on_boot on FreeBSD
evilham closed pull request ungleich-public/cdist-contrib#31 2024-05-24 11:39:02 +00:00
opendkim: fix freebsd startonboot
evilham reopened pull request ungleich-public/cdist-contrib#31 2024-05-24 11:37:16 +00:00
opendkim: fix freebsd startonboot
evilham closed pull request ungleich-public/cdist-contrib#31 2024-05-24 11:35:29 +00:00
opendkim: fix freebsd startonboot