smwltr smwltr
  • Joined on 2023-05-06
smwltr commented on pull request ungleich-public/cdist#379 2024-05-29 13:54:31 +00:00
WIP: __fail2ban new type

@fnux, sorry for the n00b question: how do I update a PR from my fork? I've pushed some changes, but I don't see them here.

smwltr commented on pull request ungleich-public/cdist#376 2024-05-29 13:53:15 +00:00
WIP: __directory to support --source path

There are no guaranties that $__remote_copy supports --delete (e.g. scp).

That is true. Oh well, if it's not wanted, we can close this.

I find it very useful to push a bunch of data to a…

smwltr commented on pull request ungleich-public/cdist#379 2024-05-29 13:41:16 +00:00
WIP: __fail2ban new type

IMO, forcing something other than the default is not my style, but if that is standard cdist style, so be it.

smwltr commented on pull request ungleich-public/cdist#379 2024-05-29 13:40:53 +00:00
WIP: __fail2ban new type

IIUC, that would mean that cdist team be responsible for shipping working tested config for fail2ban.

Do you think that is out of scope? Have you seen how many jails are in the default…

smwltr closed pull request ungleich-public/cdist#380 2024-05-19 12:25:20 +00:00
WIP: net_bridge_interfaces_d new type
smwltr commented on pull request ungleich-public/cdist#379 2024-05-19 10:30:22 +00:00
WIP: __fail2ban new type

Would it be enable-jail? I suppose we need disable-jail too. Or?

smwltr commented on pull request ungleich-public/cdist#379 2024-05-19 10:28:18 +00:00
WIP: __fail2ban new type

Is that typically what we do?

Or do we expect the user to use __start_on_boot?

Maybe I should rather fail when there is no fail2ban package installed. Then this type would be only for…

smwltr commented on pull request ungleich-public/cdist#379 2024-05-19 10:21:25 +00:00
WIP: __fail2ban new type

I'll need to make a testing set up for this. It's most likely that other OSes can use the same code, but I just haven't tested it.

smwltr commented on pull request ungleich-public/cdist#378 2024-05-19 10:19:56 +00:00
WIP: email_alias new type

There already is a __mail_alias type in cdist-contrib: https://code.ungleich.ch/ungleich-public/cdist-contrib/src/branch/master/type/__mail_alias

Ah yes. I remember now wondering why there…

smwltr commented on pull request ungleich-public/cdist#376 2024-05-19 09:57:40 +00:00
WIP: __directory to support --source path

FIXME: What does cdist use for unit testing?

We have unit tests for cdist's python code, but no integration tests for the types.

OK. I don't have anything set up for this yet, but if…

smwltr commented on pull request ungleich-public/cdist#380 2024-05-19 09:33:04 +00:00
WIP: net_bridge_interfaces_d new type

I would rather see this type in cdist-contrib as in core cdist for now. You would also need to move the logic from gencode-remote to the manifest: that's still quite a bit of work.

That makes…

smwltr commented on pull request ungleich-public/cdist#340 2024-05-09 18:33:03 +00:00
__package_apt to accept .dpk files directly

I would like to see this feature added.

If all it takes for @nico to accept it is to rm the tmp file, @fancsali, shall I add that?

smwltr pushed to net_bridge_interfaces_d at smwltr/cdist 2024-05-09 12:41:49 +00:00
6c0d1eafe3 net_bridge_interfaces_d for making bridge interfaces on debian derivatives
smwltr created pull request ungleich-public/cdist#380 2024-05-09 12:36:54 +00:00
WIP: net_bridge_interfaces_d
smwltr created branch net_bridge_interfaces_d in smwltr/cdist 2024-05-09 12:34:14 +00:00
smwltr pushed to net_bridge_interfaces_d at smwltr/cdist 2024-05-09 12:34:14 +00:00
2b2e2799ce net_bridge_interfaces_d for making bridge interfaces on debian derivatives
smwltr created pull request ungleich-public/cdist#379 2024-05-09 12:17:41 +00:00
WIP: __fail2ban
smwltr pushed to fail2ban at smwltr/cdist 2024-05-09 12:17:34 +00:00
5e09834811 __fail2ban
smwltr pushed to fail2ban at smwltr/cdist 2024-05-09 12:05:29 +00:00
f7d6c966b1 __fail2ban
smwltr created branch fail2ban in smwltr/cdist 2024-05-09 12:05:29 +00:00