Yep, awesome. If you have the time to implement this, I'll happily review and test it :)
Hmmm... Thing is, the unique identity of a key is the combination of domain/selector. So in effect, we can:
- leave the object_id, the
--selector
and--domain
independant - set the object_id…
This was a major conversation on the previous code forge; unfortunately it appears that only the initial conversation starter was saved. The situation has changed quite a bit since, and I don't…
Uuugh, pretty sure that's a loosely concentrated me trying to ease further generalization of the type without actually thinking it through. We don't use that parameter anywhere, and I don't see…
Sorry for the delay in reviewing this, @fnux isn't around so much anymore - though you were right he is "responsible" for this type.
Please fix the typo I noted in your code and rebase on the…
Huh, I was wondering why there was a PR with the same content as a git commit I'd read with interest x)
I'm happy as it is, so it's fine that you merged it. As a personal preference, I tend to…
@evilham that seems like a nice fix, I completely agree with your idea. I don't really have the time to fix this rn (unless the fix is needed for $work soon, which I don't think it will), but feel…